Paul Jackson wrote: >>> functions are used in process creation/termination, we would need to >>> keep them inline, when optimizing for performance. >> I'd keep them inline for performance reasons. > > As Matt Mackall explained more carefully in his reply, it's no longer > clear that inlining is best for performance in as many situations as > it was the past. Cache footprint size tends to dominate performance on > present day processors. True, but AFAIR, when I developed the namespaces I tried to move the task_pid_nr etc calls in kernel/pid.c and the performance on unixbench spawn and nptlperf tests became worse. That's why I said that I'd keep them inline. > See also Matt's comments on the NULL struct pid check. Getting rid > of conditional jumps may be the more important performance issue here. That's a valid argument. I will look over it. Thanks, Pavel _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
