Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> writes: > Could we just make it so dev->init is not allowed to fail? Then it > can be a void function and the nasty unwind code can go? Unfortunately we need to allocate memory, and perform other operations that can fail. That's the nature of the problem. So I think not allowing init to fail would be optimizing for the wrong the case. Allowing init to fail makes the rest of the code simpler because we don't have to perform the impossible when the highly unlikely happens. The ugly unwind is only about 5 lines of code that never need to change (except for beautification). So I don't think the cost is prohibitive. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
