Pavel Emelyanov <xemul@xxxxxxxxxx> writes: > > Rrrrrr. This is the 5th or even the 6th patch that changes tens of files > but (!) most of these changes are just propagating some core thing into > protocols, drivers, etc. E.g. you add an argument to some function and > then make all the rest use it, but the chunk adding the argument itself > is buried in these changes. > > Why not make a reviewers' lifes easier and make (with hands) the core > hunks go first and the "propagation" ones at the end? For RFC purpose > I would even break the git-bisect safeness and splitted these patches > into 2 parts: those with the core and those with the propagation. Agreed, this is an issue for easy review. My apologies. I guess it was a failure in my imagination on how to prepare these patches for review, in a way that was both reviewer and preparer friendly. There is at least one /proc idiom change that needs to be made so I will keep this in mind for the resend. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
