Paul Menage wrote: > On 9/3/07, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote: >> Paul Menage wrote: >>> On 9/2/07, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote: >>>> - s += sprintf(s, "%lu\n", *val); >>>> + if (read_strategy) >>>> + s += read_strategy(*val, s); >>>> + else >>>> + s += sprintf(s, "%lu\n", *val); >>> This would be better as %llu >>> >> Hi, Paul, >> >> This does not need fixing, since the other counters like failcnt are >> still unsigned long >> > > But val is an unsigned long long*. So printing *val with %lu will > break (at least a warning, and maybe corruption if you had other > parameters) on 32-bit archs. > Yeah... Hmm.. just wonder if all the counters should be unsigned long long? failcnt is the only remaining unsigned long counter now. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
