The function in question returns ERR_PTR-s to indicate the error, while the caller checks for return value to be NULL. Found during testing the OpenVZ kernel with pid namespaces. Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxxx> Cc: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx> Cc: Oleg Nesterov <oleg@xxxxxxxxxx> --- kernel/pid.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid.c b/kernel/pid.c index faad017..cb1f3cb 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -543,7 +543,7 @@ struct pid_namespace *copy_pid_ns(unsign goto out_put; new_ns = create_pid_namespace(old_ns->level + 1); - if (new_ns != NULL) + if (!IS_ERR(new_ns)) new_ns->parent = get_pid_ns(old_ns); out_put: _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
