On 06/17, Herbert Poetzl wrote: > > On Sun, Jun 17, 2007 at 06:38:30PM +0400, Oleg Nesterov wrote: > > > > At first glance, sys_unshare() drops the reference to > > the old nsproxy, > > okay, the 'current' task has an nsproxy, and keeps > a reference to that (let's assume it is the only > task using this nsproxy, then the count will be 1) > > unshare_nsproxy_namespaces() now does get_nsproxy() > which makes the count=2, then it creates a new > nsproxy (which will get count=1), and returns ... Ah yes, stupid me. Looks like we should just remove get/put old_ns from unshare_nsproxy_namespaces() as you suggested. Thanks! Oleg. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers