From: Dave Hansen <hansendc@xxxxxxxxxx> ext3_change_inode_journal_flag() is only called from one location: ext3_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen <hansendc@xxxxxxxxxx> --- --- fs/ext3/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6.22-rc4-mm2-robindmount/fs/ext3/inode.c =================================================================== --- 2.6.22-rc4-mm2-robindmount.orig/fs/ext3/inode.c +++ 2.6.22-rc4-mm2-robindmount/fs/ext3/inode.c @@ -3235,7 +3235,7 @@ int ext3_change_inode_journal_flag(struc */ journal = EXT3_JOURNAL(inode); - if (is_journal_aborted(journal) || IS_RDONLY(inode)) + if (is_journal_aborted(journal)) return -EROFS; journal_lock_updates(journal); -- _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers