Benjamin Thery <benjamin.thery@xxxxxxxx> writes:
> I tried to activate the checksum offload on etun to see if it improves things,
> but, unfortunately once activated all my traffic was lost or blocked. I didn't
> spend a lot of time on the issue. May be I'll give it another try.
No problem.
I don't much care right now once we have isolated the problem down to the
extra hops needed to reach the outside world.
> BTW, there is a small bug in etun_set_tx_csum. We can't disable the checksum
> offloading once it has been set. I think it should look like this: (sorry I
> haven't a patch ready)
>
> static int etun_set_tx_csum(struct net_device *dev, u32 data)
> {
> if (data)
> dev->features |= NETIF_F_NO_CSUM;
> else
> dev->features &= ~NETIF_F_NO_CSUM;
> return 0;
> }
Looking at the code I would actually say looking like:
static int etun_set_tx_csum(struct net_device *dev, u32 data)
{
dev->features &= ~NETIF_F_NO_CSUM;
if (data)
dev->features |= NETIF_F_NO_CSUM;
return 0;
}
Is what I intended. It seems I forgot the ~.....
Oops.
Eric
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
