On Mon, Feb 12, 2007 at 12:15:24AM -0800, menage@xxxxxxxxxx wrote: > +static int attach_task(struct container *cont, struct task_struct *tsk) > { [snip] > + for_each_subsys(h, ss) { > + if (ss->can_attach) { > + retval = ss->can_attach(ss, cont, tsk); > + if (retval) { > + put_task_struct(tsk); We don't need this put_task_struct(), since our caller attach_task_by_pid() would do it for us. > + return retval; > + } > + } > } > -} > > + /* Locate or allocate a new container_group for this task, > + * based on its final set of containers */ > + oldcg = tsk->containers; > + newcg = find_container_group(oldcg, cont); > + if (!newcg) { > + put_task_struct(tsk); Ditto > + return -ENOMEM; > + } -- Regards, vatsa _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers