Re: [RFC][PATCH 06/14] Populate pid_nrs list with entry for init-pid-ns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



sukadev@xxxxxxxxxx writes:
> Signed-off-by: Cedric Le Goater <clg@xxxxxxxxxx>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>
> ---
>  include/linux/pid.h |    9 ------
>  kernel/pid.c | 73 ++++++++++++++++++++++++++++++++++------------------
>  2 files changed, 50 insertions(+), 32 deletions(-)
>

> @@ -242,50 +247,70 @@ struct pid_nr *alloc_pid_nr(struct pid_n
>  	 */
>  	pid_nr->pid = pid;
>
> +	spin_lock_irq(&pidmap_lock);
> +	hlist_add_head_rcu(&pid_nr->pid_chain, &pid_hash[pid_hashfn(nr)]);
> +	spin_unlock_irq(&pidmap_lock);
> +

Hmm.  I think we really need to hash in some of the bits of the
pid_namespace so processes with identical pids don't get put on
the same hash chain.  It isn't critical but it is a good idea.

Eric
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers


[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux