Re: [Devel] [PATCH 4/4] Use task_pgrp() in autofs/autofs4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric W. Biederman [ebiederm@xxxxxxxxxxxx] wrote:
| Cedric Le Goater <clg@xxxxxxxxxx> writes:
| 
| > sukadev@xxxxxxxxxx wrote:
| >> From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>
| >> Subject: [PATCH 4/4] Use task_pgrp() in autofs/autofs4
| >> 
| >> Replace process_group(tsk) with pid_nr(task_pgrp(tsk)) in autofs and autofs4.
| >
| > you will need EXPORT_SYMBOL_GPL for pid_nr()

Cedric: do we need the export in -mm or just in -lxc ? In -mm, for now,
this is an inline function in pid.h and should just get included into
the file(s) no ?

| 
| This bit I can agree with.  Because you need that at least for
| the seq_printf.
| 
| However all of the pid_nr(task_pgrp) stuff just appears to be painful
| noise.  

Ok. I thought they were low priority but required eventually.

| 
| I have largely given up on review this patch set until that is fixed.

I am sending out the patches with the noise cancelled :-) Would like
to send them out to akpm in a few days.

Suka
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxx
https://lists.osdl.org/mailman/listinfo/containers


[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux