-------- Original Message -------- Subject: Re: [Devel] [patch 05/20] [Network namespace] Add NS_NET3 to NS_ALL. Date: Mon, 11 Dec 2006 11:28:55 +0100 From: Daniel Lezcano <dlezcano at fr.ibm.com> To: Dmitry Mishin <dim at openvz.org> References: <20061210215817.488715867 at localhost.localdomain> <20061210220132.683812588 at localhost.localdomain> <200612111138.26786.dim at openvz.org> Dmitry Mishin wrote: > On Monday 11 December 2006 00:58, dlezcano at fr.ibm.com wrote: >> Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com> >> >> --- >> >> include/linux/nsproxy.h | 2 +- >> 1 files changed, 1 insertion(+), 1 deletion(-) >> >> Index: 2.6.19-rc6-mm2/include/linux/nsproxy.h >> =================================================================== >> --- 2.6.19-rc6-mm2.orig/include/linux/nsproxy.h >> +++ 2.6.19-rc6-mm2/include/linux/nsproxy.h >> @@ -23,7 +23,7 @@ struct user_namespace; >> #define NS_NET2 0x00000010 >> #define NS_USER 0x00000020 >> #define NS_NET3 0x00000040 >> -#define NS_ALL (NS_MNT|NS_UTS|NS_IPC|NS_PID|NS_NET2|NS_USER) >> +#define NS_ALL (NS_MNT|NS_UTS|NS_IPC|NS_PID|NS_NET2|NS_USER|NS_NET3) > And you'll unshare both NS_NET2 and NS_NET3 during sys_unshare(NS_ALL)... Oops. But, sys_unshare_ns() { ... if (unshare_ns_flags & ~NS_ALL) ... } will fail with NS_NET3...