On Wed, Jul 18, 2018 at 05:01:52AM +0200, Adam Borowski wrote: > Hi! > Here's a patchset with two entangled improvements: > > * it'd be good to get rid of blinking where possible. Even CGA (thus VGA) > allows disabling it, rendering such characters with a bright background > instead. > * due to my error, 256-color mode uses a much darker palette for conversion, > resulting in behaving inconsistently with 24-bit mode. > > The new code uses bright backgrounds when possible, enabled with \e[100m or > \e[48;m. > > Despite the whole idea following a VGA capability, this patchset doesn't > change vgacon yet, just fbcon. The reason being: ~80% of x86 users have an > nVidia chip, which means nouveau or nvidia-proprietary. Nouveau implies > fbcon, nvidia-proprietary fails to properly restore text flags (as evidenced > by 512 glyph mode turning to 256 on switch from graphics). You don't care > about the proprietary driver, but let's not break it pointlessly, and as > both nVidia cards I own work only with nouveau, I don't want to touch what I > can't test. > > Thus, let's enable unblinking on fbcon for now. We can flip that bit (in > register 0x10) later. > > This fixes the display of catimg and similar tools. I've applied the first patch, as it was obvious :) For the rest, can you make it a config option as Alan said? And I agree, we don't care about breaking nvidia systems, go ahead :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-console" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
