On Wed, Mar 19, 2025 at 6:17 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Tue, Mar 18, 2025 at 09:38:26PM +0900, Namjae Jeon wrote: > > This reverts commit ecce70cf17d91c3dd87a0c4ea00b2d1387729701. > > > > Revert the GUID trick code causing the layering violation. > > I will try to allow the users to turn RDMA-capable on/off via sysfs later > > > > Cc: Kangjing Huang <huangkangjing@xxxxxxxxx> > > Cc: Leon Romanovsky <leon@xxxxxxxxxx> > > Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxxx> > > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx> > > --- > > fs/smb/server/transport_rdma.c | 40 +++++++++------------------------- > > 1 file changed, 10 insertions(+), 30 deletions(-) > > > > diff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c > > index 1b9f3aee8b4b..9837a41641ce 100644 > > --- a/fs/smb/server/transport_rdma.c > > +++ b/fs/smb/server/transport_rdma.c > > @@ -2142,7 +2142,8 @@ static int smb_direct_ib_client_add(struct ib_device *ib_dev) > > if (ib_dev->node_type != RDMA_NODE_IB_CA) > > smb_direct_port = SMB_DIRECT_PORT_IWARP; > > > > - if (!rdma_frwr_is_supported(&ib_dev->attrs)) > > + if (!ib_dev->ops.get_netdev || > > + !rdma_frwr_is_supported(&ib_dev->attrs)) > > <...> > > > + ndev = smb_dev->ib_dev->ops.get_netdev(smb_dev->ib_dev, > > + i + 1); > > Can you please use ib_device_get_netdev()? > ULPs are not supposed to call to ops.* directly. Okay, I will do that in another patch. Thanks! > > Thanks
