Re: [PATCH] cifs: Fix printing Status code into dmesg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 20, 2025 at 11:55 AM Pali Rohár <pali@xxxxxxxxxx> wrote:
>
> Just to note that I have sent this patch in series with "cifs: Add
> missing NT_STATUS_* codes from nterr.h to nterr.c" patch which is adding
> also NT_STATUS_STOPPED_ON_SYMLINK (mentioned in commit message):
>
> https://lore.kernel.org/linux-cifs/20241227173709.22892-1-pali@xxxxxxxxxx/t/#u

Both of these are in for-next

> On Sunday 19 January 2025 19:48:39 Steve French wrote:
> > Any thoughts on the attached patch (which is tentatively in
> > cifs-2.6.git for-next)?
> >
> > NT Status code is 32-bit number, so for comparing two NT Status codes is
> > needed to check all 32 bits, and not just low 24 bits.
> >
> > Before this change kernel printed message:
> > "Status code returned 0x8000002d NT_STATUS_NOT_COMMITTED"
> >
> > It was incorrect as because NT_STATUS_NOT_COMMITTED is defined as
> > 0xC000002d and 0x8000002d has defined name NT_STATUS_STOPPED_ON_SYMLINK.
> >
> > With this change kernel prints message:
> > "Status code returned 0x8000002d NT_STATUS_STOPPED_ON_SYMLINK"
> >
> > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> >
> >
> > --
> > Thanks,
> >
> > Steve



-- 
Thanks,

Steve





[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux