Re: [PATCH] cifs: Fix endian types in struct rfc1002_session_packet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 19 January 2025 13:21:39 Steve French wrote:
>     > All fields in struct rfc1002_session_packet are in big endian. This is
>     > because all NetBIOS packet headers are in big endian as opposite of SMB
>     >structures which are in little endian.
>     > Therefore use __be16 and __be32 types instead of __u16 and __u32 in
>     >struct rfc1002_session_packet.
>     >
>     >Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> Do you have a link to the kernel bot reported by (email?)

I should have it somewhere in my mailbox. I if needed I can try to find it.

But robot reported this issue for my own branch (not the master one). So
I though that it is not important to mention exact link for some of my
change which was work-in-progress.

In any case, robot found the issue with incorrect endianity types, so I
wanted to give credits for this robot. Anyway, those type changes should
not change compiled code, just allows code analysis tool to diagnose
other issues.




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux