On Wed, Nov 27, 2024 at 11:07 AM Enzo Matsumiya <ematsumiya@xxxxxxx> wrote: > > On 11/27, Steve French wrote: > >I did see the generic/241 failure again with current for-next > >(unrelated to this patch though). Will try to repro it again - but > >any ideas how to narrow it down or fix it would be helpful. > > We're seeing this too when backporting that patch series to SLE15-SP6, > by only running generic/072, so I don't think it's unrelated. > > We also hit, also with generic/072, but only once, the WARN() in > cached_dir_offload_close() (introduced in this same patch): > > [ 526.946722] WARNING: CPU: 2 PID: 23778 at fs/smb/client/cached_dir.c:555 cached_dir_offload_close+0x90/0xa0 [cifs] > [ 526.948561] Modules linked in: cifs cifs_arc4 cifs_md4 > [ 526.949385] CPU: 2 PID: 23778 Comm: kworker/2:1 Kdump: loaded Not tainted 6.4.0-lku #91 SLE15-SP6 (unreleased) > [ 526.949394] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-2-gc13ff2cd-prebuilt.qemu.org 04/01/2014 > [ 526.949398] Workqueue: serverclose cached_dir_offload_close [cifs] > [ 526.951938] RIP: 0010:cached_dir_offload_close+0x90/0xa0 [cifs] > [ 526.953827] Code: e8 a5 fb ff ff 4c 89 e7 5b 5d 41 5c e9 99 57 fc ff 48 89 ef be 03 00 00 00 e8 5c d4 c5 c9 4c 89 e7 5b 5d 41 5c e9 80 57 fc ff <0f> 0b eb 99 66 66 2e 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 > [ 526.953836] RSP: 0018:ffff888108b7fdd8 EFLAGS: 00010202 > [ 526.953844] RAX: 0000000000000000 RBX: ffff888100de68d0 RCX: ffffffffc042e7d4 > [ 526.953849] RDX: 1ffff110201bcd04 RSI: 0000000000000008 RDI: ffff888100de6820 > [ 526.953854] RBP: ffff8881063d8a00 R08: 0000000000000001 R09: ffffed10201bcd1a > [ 526.953858] R10: ffff888100de68d7 R11: 0000000000000000 R12: ffff888100a2b000 > [ 526.953862] R13: 0000000000000080 R14: ffff88814f336ea8 R15: ffff888100de68d8 > [ 526.953872] FS: 0000000000000000(0000) GS:ffff88814f300000(0000) knlGS:0000000000000000 > [ 526.965888] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 526.965897] CR2: 00007f841e6ea698 CR3: 0000000106c68000 CR4: 0000000000750ee0 > [ 526.965904] PKRU: 55555554 > [ 526.965908] Call Trace: > [ 526.965912] <TASK> > [ 526.965917] ? __warn+0x92/0xf0 > [ 526.965932] ? cached_dir_offload_close+0x90/0xa0 [cifs] > [ 526.972634] ? report_bug+0x163/0x190 > [ 526.972652] ? handle_bug+0x3a/0x70 > [ 526.972665] ? exc_invalid_op+0x17/0x40 > [ 526.972674] ? asm_exc_invalid_op+0x1a/0x20 > [ 526.972688] ? cached_dir_offload_close+0x24/0xa0 [cifs] > [ 526.977239] ? cached_dir_offload_close+0x90/0xa0 [cifs] > [ 526.978831] ? cached_dir_offload_close+0x24/0xa0 [cifs] > [ 526.979133] process_one_work+0x42c/0x730 > [ 526.979176] worker_thread+0x8e/0x700 > [ 526.979190] ? __pfx_worker_thread+0x10/0x10 > [ 526.979200] kthread+0x197/0x1d0 > [ 526.979208] ? kthread+0xeb/0x1d0 > [ 526.979216] ? __pfx_kthread+0x10/0x10 > [ 526.979225] ret_from_fork+0x29/0x50 > [ 526.979237] </TASK> > [ 526.979241] ---[ end trace 0000000000000000 ]--- > > Will update here if we find a fix/root cause. > > > Cheers, > > Enzo Presumably it is related to the dir lease series but one of the earlier ones not the most recent one, since we saw it running before - but without the patch series we saw the unmount crash when racing with freeing cached dentries so would be helpful to narrow the bug down so we can fix the original problem that has been around for quite a while now - especially important now that more servers will be enabling directory leases (e.g. Samba can now be tested against) -- Thanks, Steve
