man: Incorrect description of mapchars and mapposix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I believe the manpage is incorrect here:

mount.cifs(8) (as of cifs-utils 7.1):
> mapchars
> Translate [...] reserved characters  to the remap range (above 0xF000),
> which also allows the CIFS client to recognize files created with such
> characters by Windows's Services for Mac. [...]
> [...]
> mapposix
> Translate reserved characters similarly to mapchars but use the mapping
> from Microsoft "Services For Unix".

Inspecting the logic in fs/smb/client/fs_context.c (as of 6.12),

    case Opt_mapposix:
        if (result.negated)
            ctx->remap = false;
        else {
            ctx->remap = true;
            ctx->sfu_remap = false; /* disable SFU mapping */
        }
        break;
    case Opt_mapchars:
        if (result.negated)
            ctx->sfu_remap = false;
        else {
            ctx->sfu_remap = true;
            ctx->remap = false; /* disable SFM (mapposix) mapping */
        }
        break;

it seems that the opposite is true. Given SFM also deals with trailing
periods and spaces, I think the minimally invasive fix is to swap words "Mac"
and "Unix". And maybe mention the period/space thing in mapposix.

(Also, please s/asterik/asterisk/ in mapchars.)

Hope this makes sense.




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux