On Thu, Nov 14, 2024 at 06:52:14AM +1000, ronnie sahlberg wrote:
On Thu, 14 Nov 2024 at 05:07, Ralph Boehme <slow@xxxxxxxxx> wrote:
On 11/13/24 4:39 PM, Ralph Boehme wrote:
> Am I missing anything? Thoughts?
did some more research on what the option modefromsid actually does and
I guess the problem is that the behaviour is likely correct for
modefromsid, it just doesn't work for smb3 posix, so populate_new_aces()
needs to be tweaked to not include sid_authusers.
Remember, it also need to work for use-cases with normal Windows and
Azure servers where you do NOT
have a multiuser mount (i.e. all client access is using the
credentials from the mount)
and you basically have an inherited ACE to "allow all access to the
mount user" for the whole share.
This is different from the SMB3-POSIX chmod operation.
I think Ralph is suggesting the modefromsid is left alone,
and a new (separate) code path used for SMB3-POSIX that
sends the one-ACE entry defined in that spec.
