On Tue, Oct 08, 2024 at 11:35:16AM +0200, Ralph Boehme via samba-technical wrote:
On 10/8/24 10:45 AM, Ralph Boehme wrote:
On 10/8/24 10:41 AM, Ralph Boehme via samba-technical wrote:
The problem is the O_APPEND on the destination file handle.
We pass that flag if
if (posix_open && (access_mask & FILE_APPEND_DATA)) {
flags |= O_APPEND;
}
Is this on a posix mount? Otherwise it seems to be the clients
fault passing FILE_APPEND_DATA.
gah, it's an "&&", not an "||", so it's your client I would say.
thinking about it, I wonder whether that condition is actually useful
or if we should remove it.
@Jeremy (or others): mapping from FILE_APPEND_DATA access mask to open
flag O_APPEND seems wrong imho. Do you remember why you added it? Or
anyone else?
It was done as part of the SMB1 extensions - trying to "pass-through" all
possible POSIX open flags.
Just remove it.
