[cifs:for-next 12/25] fs/smb/client/transport.c:437:24: error: implicit declaration of function 'smb_compress'; did you mean 'cra_compress'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
head:   2716e3ac61b56a9da0072911d96144578c39e750
commit: f046d71e84e1e94cf23335129a27f5cfe3e8b75f [12/25] smb: client: insert compression check/call on write requests
config: x86_64-rhel-8.3-bpf (https://download.01.org/0day-ci/archive/20240916/202409160825.dssj4HmQ-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240916/202409160825.dssj4HmQ-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409160825.dssj4HmQ-lkp@xxxxxxxxx/

Note: the cifs/for-next HEAD 2716e3ac61b56a9da0072911d96144578c39e750 builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   fs/smb/client/transport.c: In function 'smb_send_rqst':
>> fs/smb/client/transport.c:437:24: error: implicit declaration of function 'smb_compress'; did you mean 'cra_compress'? [-Werror=implicit-function-declaration]
     437 |                 return smb_compress(server, &rqst[0], __smb_send_rqst);
         |                        ^~~~~~~~~~~~
         |                        cra_compress
   cc1: some warnings being treated as errors
--
   fs/smb/client/smb2pdu.c: In function 'smb2_async_writev':
>> fs/smb/client/smb2pdu.c:5025:69: error: implicit declaration of function 'should_compress' [-Werror=implicit-function-declaration]
    5025 |         if (((flags & CIFS_TRANSFORM_REQ) != CIFS_TRANSFORM_REQ) && should_compress(tcon, &rqst))
         |                                                                     ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +437 fs/smb/client/transport.c

   426	
   427	static int
   428	smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
   429		      struct smb_rqst *rqst, int flags)
   430	{
   431		struct send_req_vars *vars;
   432		struct smb_rqst *cur_rqst;
   433		struct kvec *iov;
   434		int rc;
   435	
   436		if (flags & CIFS_COMPRESS_REQ)
 > 437			return smb_compress(server, &rqst[0], __smb_send_rqst);
   438	
   439		if (!(flags & CIFS_TRANSFORM_REQ))
   440			return __smb_send_rqst(server, num_rqst, rqst);
   441	
   442		if (WARN_ON_ONCE(num_rqst > MAX_COMPOUND - 1))
   443			return -EIO;
   444	
   445		if (!server->ops->init_transform_rq) {
   446			cifs_server_dbg(VFS, "Encryption requested but transform callback is missing\n");
   447			return -EIO;
   448		}
   449	
   450		vars = kzalloc(sizeof(*vars), GFP_NOFS);
   451		if (!vars)
   452			return -ENOMEM;
   453		cur_rqst = vars->rqst;
   454		iov = &vars->iov;
   455	
   456		iov->iov_base = &vars->tr_hdr;
   457		iov->iov_len = sizeof(vars->tr_hdr);
   458		cur_rqst[0].rq_iov = iov;
   459		cur_rqst[0].rq_nvec = 1;
   460	
   461		rc = server->ops->init_transform_rq(server, num_rqst + 1,
   462						    &cur_rqst[0], rqst);
   463		if (rc)
   464			goto out;
   465	
   466		rc = __smb_send_rqst(server, num_rqst + 1, &cur_rqst[0]);
   467		smb3_free_compound_rqst(num_rqst, &cur_rqst[1]);
   468	out:
   469		kfree(vars);
   470		return rc;
   471	}
   472	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux