On Wed, Sep 11, 2024 at 8:01 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Mon, 9 Sep 2024 22:30:19 -0400 Xin Long wrote: > > This commit introduces build configurations for QUIC within the networking > > subsystem. The Kconfig and Makefile files in the net directory are updated > > to include options and rules necessary for building QUIC protocol support. > > Don't split out trivial config changes like this, what's the point. > It just make build testing harder. I will move this to the Patch 3/5. > > Speaking of which, it doesn't build on 32bit: > > ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined! > ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined! > ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined! The tests were done on x86_64, aarch64, s390x and ppc64le. Sorry for missing 32bit machines. > > If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf > we won't have enough time to review for 6.12 even if Linus cuts -rc8. Copy that. Thanks.