I plan to send it upstream this week, so should make it into some
distros fairly soon after that.
On Thu, Aug 22, 2024 at 7:06 PM Marc <1marc1@xxxxxxxxx> wrote:
>
> Thank you all for working on this and resolving this issue so quickly.
> Am I correct to assume that this update will eventually flow through
> in an update on my Ubuntu desktop?
>
> Regards, /|/|arc.
>
> Op do 22 aug 2024 om 03:58 schreef Steve French <smfrench@xxxxxxxxx>:
> >
> > thx for testing this. Have added your tested-by. Let me know if any
> > followon patches or issues.
> >
> > On Wed, Aug 21, 2024 at 12:43 PM Anthony Nandaa <profnandaa@xxxxxxxxx> wrote:
> > >
> > > I have now tested the patch.
> > >
> > > On Wed, 21 Aug 2024 at 18:55, Anthony Nandaa <profnandaa@xxxxxxxxx> wrote:
> > > >
> > > > I can help with this. Marc, if you can help me with the minimal repro steps, is OneDrive needed?
> > > >
> > > >
> > > > On Wed, Aug 21, 2024, 15:15 Marc <1marc1@xxxxxxxxx> wrote:
> > > >>
> > > >> Happy to help and assist where I can, but I have no idea how I would
> > > >> try this updated code. I think it involves compiling a kernel and
> > > >> applying the patch to it. This is not something I have ever done or
> > > >> have an idea on how to go about it.
> > > >>
> > > >>
> > > >> Op wo 21 aug 2024 om 09:45 schreef Paulo Alcantara <pc@xxxxxxxxxxxxx>:
> > > >> >
> > > >> > Marc <1marc1@xxxxxxxxx> writes:
> > > >> >
> > > >> > > This has been working great for many years. Yesterday, this stopped
> > > >> > > working. When I tried mounting the share, I would get the following
> > > >> > > error: "mount error(95): Operation not supported". In dmesg I see:
> > > >> > > "VFS: parse_reparse_point: unhandled reparse tag: 0x9000601a" and
> > > >> > > "VFS: cifs_read_super: get root inode failed".
> > > >> >
> > > >> > Can you try the following changes? Thanks.
> > > >> >
> > > I see that the patch is in
> > > for-next@80dd92d6ac7d1bc4b95d0a9f4d7730fe5ee42162, so I have just used
> > > that to build a new module.
> > >
> > > I created a share from one of the directories in my OneDrive:
> > >
> > > sudo mount -t cifs //WIN-31GSG2M9E6N/Users/Usa/OneDrive/Shuttle
> > > /mnt/shuttle -o username=...,password=...
> > >
> > > Before the patch, the mounting was failing but after building with the
> > > patch, it mounted successfully.
> > >
> > > Aug 21 17:25:32 ubuntu-test-2 kernel: CIFS: VFS: parse_reparse_point:
> > > unhandled reparse tag: 0x9000601a
> > > Aug 21 17:25:32 ubuntu-test-2 kernel: CIFS: VFS: cifs_read_super: get
> > > root inode failed <~~~~ FAIL
> > > ...
> > > Aug 21 17:31:22 ubuntu-test-2 kernel: CIFS: Attempting to mount
> > > //WIN-31GSG2M9E6N/Users/Administrator/OneDrive/Shuttle
> > > ...
> > > Aug 21 17:31:22 ubuntu-test-2 kernel: CIFS: VFS:
> > > \\WIN-31GSG2M9E6N\Users unhandled reparse tag: 0x9000601a
> > > ^^^ SUCCESS.
> > >
> > > >> > diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c
> > > >> > index 689d8a506d45..48c27581ec51 100644
> > > >> > --- a/fs/smb/client/reparse.c
> > > >> > +++ b/fs/smb/client/reparse.c
> > > >> > @@ -378,6 +378,8 @@ int parse_reparse_point(struct reparse_data_buffer *buf,
> > > >> > u32 plen, struct cifs_sb_info *cifs_sb,
> > > >> > bool unicode, struct cifs_open_info_data *data)
> > > >> > {
> > > >> > + struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
> > > >> > +
> > > >> > data->reparse.buf = buf;
> > > >> >
> > > >> > /* See MS-FSCC 2.1.2 */
> > > >> > @@ -394,12 +396,13 @@ int parse_reparse_point(struct reparse_data_buffer *buf,
> > > >> > case IO_REPARSE_TAG_LX_FIFO:
> > > >> > case IO_REPARSE_TAG_LX_CHR:
> > > >> > case IO_REPARSE_TAG_LX_BLK:
> > > >> > - return 0;
> > > >> > + break;
> > > >> > default:
> > > >> > - cifs_dbg(VFS, "%s: unhandled reparse tag: 0x%08x\n",
> > > >> > - __func__, le32_to_cpu(buf->ReparseTag));
> > > >> > - return -EOPNOTSUPP;
> > > >> > + cifs_tcon_dbg(VFS | ONCE, "unhandled reparse tag: 0x%08x\n",
> > > >> > + le32_to_cpu(buf->ReparseTag));
> > > >> > + break;
> > > >> > }
> > > >> > + return 0;
> > > >> > }
> > > >> >
> > > >> > int smb2_parse_reparse_point(struct cifs_sb_info *cifs_sb,
> > > >>
> > >
> > >
> > > --
> > > ___
> > > Nandaa Anthony
> > >
> >
> >
> > --
> > Thanks,
> >
> > Steve
--
Thanks,
Steve
