Re: [PATCH] fs: smb: common: add missing MODULE_DESCRIPTION() macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/26/2024 3:44 PM, Steve French wrote:
merged into cifs-2.6.git for-next

On Sun, May 26, 2024 at 11:53 AM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:

Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/common/cifs_arc4.o
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/smb/common/cifs_md4.o

Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>

Would it be worth adding the word "DEPRECATED" (or some such)?
These are present only for SMB1 down-compat, and we don't want
people to think they're generally useful.

Tom.

---
  fs/smb/common/cifs_arc4.c | 1 +
  fs/smb/common/cifs_md4.c  | 1 +
  2 files changed, 2 insertions(+)

diff --git a/fs/smb/common/cifs_arc4.c b/fs/smb/common/cifs_arc4.c
index 043e4cb839fa..df360ca47826 100644
--- a/fs/smb/common/cifs_arc4.c
+++ b/fs/smb/common/cifs_arc4.c
@@ -10,6 +10,7 @@
  #include <linux/module.h>
  #include "arc4.h"

+MODULE_DESCRIPTION("ARC4 Cipher Algorithm");
  MODULE_LICENSE("GPL");

  int cifs_arc4_setkey(struct arc4_ctx *ctx, const u8 *in_key, unsigned int key_len)
diff --git a/fs/smb/common/cifs_md4.c b/fs/smb/common/cifs_md4.c
index 50f78cfc6ce9..7ee7f4dad90c 100644
--- a/fs/smb/common/cifs_md4.c
+++ b/fs/smb/common/cifs_md4.c
@@ -24,6 +24,7 @@
  #include <asm/byteorder.h>
  #include "md4.h"

+MODULE_DESCRIPTION("MD4 Message Digest Algorithm (RFC1320)");
  MODULE_LICENSE("GPL");

  static inline u32 lshift(u32 x, unsigned int s)

---
base-commit: 416ff45264d50a983c3c0b99f0da6ee59f9acd68
change-id: 20240526-md-fs-smb-common-e92031f7d8cf








[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux