On Thu, Apr 25, 2024 at 11:23 PM Steve French <smfrench@xxxxxxxxx> wrote: > > Minor update to patch (shrink slightly by using a goto) > > > On Thu, Apr 25, 2024 at 12:44 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > On Wed, Apr 24, 2024 at 9:16 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > Coverity spotted that the cifs_sync_mid_result function could deadlock > > > since cifs_server_dbg graps the srv_lock while we are still holding > > > the mid_lock > > > > > > "Thread deadlock (ORDER_REVERSAL) lock_order: Calling spin_lock acquires > > > lock TCP_Server_Info.srv_lock while holding lock TCP_Server_Info.mid_lock" > > > > > > Addresses-Coverity: 1590401 ("Thread deadlock (ORDER_REVERSAL)") > > > > > > See attached patch > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > Looks good to me. > > > > -- > > Regards, > > Shyam > > > > -- > Thanks, > > Steve This one looks even better. Thanks. -- Regards, Shyam