David, Thanks for the patch! Merged it to https://github.com/piastry/cifs-utils/commit/770e891a8b7ad53d4d700e08cf8d3154028b4588. I removed a blank line and a style change around addr->ai_protocol != IPPROTO_TCP check in resolve_host.c. Let me know if it is ok with you. Jacob, Paulo, Thanks for the testing! Let me know if you want me to add "Reviewed-and-Tested-by: " tags to the commit. -- Best regards, Pavel Shilovsky вт, 16 апр. 2024 г. в 06:09, David Voit <david.voit@xxxxxxxxx>: > > Thanks for all the reviews! Please let me know If you need any changes. I didn't got any other off-list feedback and in my point of view this is now in a ready for merge state. > > Paulo Alcantara <pc@xxxxxxxxxxxxx> schrieb am Mi., 10. Apr. 2024, 21:08: >> >> David Voit <david.voit@xxxxxxxxx> writes: >> >> > For domain based DFS we always need to contact the domain controllers. >> > On setups, which are using bigger AD installations you could get random dc on the other side of the world, >> > if you don't have site support. This can lead to network timeouts and other problems. >> > >> > CLDAP-Ping uses ASN.1 + UDP (CLDAP) and custom-DCE encoding including DName compressions without >> > field separation. Finally after finding the sitename we now need to do a DNS SRV lookups to find >> > the correct IPs to our closest site and fill up the remaining IPs from the global list. >> > >> > Signed-off-by: David Voit <david.voit@xxxxxxxxx> >> > --- >> > Makefile.am | 15 ++- >> > cldap_ping.c | 346 +++++++++++++++++++++++++++++++++++++++++++++++++ >> > cldap_ping.h | 14 ++ >> > mount.cifs.c | 5 +- >> > resolve_host.c | 258 +++++++++++++++++++++++++++++++----- >> > resolve_host.h | 6 +- >> > 6 files changed, 606 insertions(+), 38 deletions(-) >> > create mode 100644 cldap_ping.c >> > create mode 100644 cldap_ping.h >> >> Great work! I've tested it and found no issues. >> >> Most of the cifs-utils code seems to follow the Linux kernel coding >> style, but I don't see it being mentioned anywhere, so the patch looks >> good. >> >> Thanks!
