Re: [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Marios Makassikis <mmakassikis@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 20 Feb 2024 22:44:56 -0800
Cc: linux-cifs@xxxxxxxxxxxxxxx
In-reply-to: <20240220142601.3624584-2-mmakassikis@freebox.fr>
References: <20240220142601.3624584-1-mmakassikis@freebox.fr> <20240220142601.3624584-2-mmakassikis@freebox.fr>

On Tue, Feb 20, 2024 at 03:26:01PM +0100, Marios Makassikis wrote:
> Use vfs_getattr() as inode->i_blocks may be 0 on some filesystems (XFS
> for example).

Same comment as for patch 1.  The code changes also look good to me.

References:
- [PATCH 1/2] ksmbd: replace generic_fillattr with vfs_getattr
  - From: Marios Makassikis
- [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
  - From: Marios Makassikis

Prev by Date: Re: [PATCH 1/2] ksmbd: replace generic_fillattr with vfs_getattr
Next by Date: Re: [REGRESSION 6.1.70] system calls with CIFS mounts failing with "Resource temporarily unavailable"
Previous by thread: [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
Next by thread: Re: [PATCH 2/2] ksmbd: retrieve number of blocks using vfs_getattr in set_file_allocation_info
Index(es):
- Date
- Thread

[Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux