On Tue, Feb 20, 2024 at 1:32 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Tue, Feb 20, 2024 at 12:09:17PM -0600, Steve French wrote: > > FYI - I hit this oops in xfstests (around generic/048) today. This is > > with 6.8-rc5 > > > > Any thoughts? > > Umm, this isn't an oops, it's just a backtrace. Do you have anything > that was printed before the backtrace? I'd expect to see something > complaining about sleeping for too long, since this is where we wait for > writeback to finish ... the bug is probably something not calling > folio_end_writeback() when it should. That makes more sense - looking at the saved kernel log I do see evidence that writes could have timed out (in this case due to reconnects to a Windows server repeatedly failing) 2024-02-20T12:05:52.416215-06:00 smfrench-ThinkPad-P52 kernel: [125520.747835] CIFS: VFS: No writable handle in writepages rc=-9 2024-02-20T12:05:55.743942-06:00 smfrench-ThinkPad-P52 kernel: [125524.077358] CIFS: VFS: \\ has not responded in 180 seconds. Reconnecting... 2024-02-20T12:05:57.024052-06:00 smfrench-ThinkPad-P52 kernel: [125524.077367] CIFS: VFS: unable to get chan index for server: 0x2bf 2024-02-20T12:05:57.024077-06:00 smfrench-ThinkPad-P52 kernel: [125525.357444] CIFS: VFS: \\ has not responded in 180 seconds. Reconnecting... 2024-02-20T12:05:57.024080-06:00 smfrench-ThinkPad-P52 kernel: [125525.357469] CIFS: VFS: unable to get chan index for server: 0x2c0 And interestingly I also see some "invalid argument" errors later which I have not seen for session setup before. 2024-02-20T12:06:17.048083-06:00 smfrench-ThinkPad-P52 kernel: [125545.382363] CIFS: VFS: \\ Send error in SessSetup = -22 > > 125545.834971] task:xfs_io state:D stack:0 pid:1697299 > > tgid:1697299 ppid:1692194 flags:0x00004002 > > [125545.834987] Call Trace: > > [125545.834992] <TASK> > > [125545.835002] __schedule+0x2cb/0x760 > > [125545.835022] schedule+0x33/0x110 > > [125545.835031] io_schedule+0x46/0x80 > > [125545.835039] folio_wait_bit_common+0x136/0x330 > > [125545.835052] ? __pfx_wake_page_function+0x10/0x10 > > [125545.835069] folio_wait_bit+0x18/0x30 > > [125545.835076] folio_wait_writeback+0x2b/0xa0 > > [125545.835087] __filemap_fdatawait_range+0x93/0x110 > > [125545.835104] filemap_write_and_wait_range+0x94/0xc0 > > [125545.835120] cifs_flush+0x9a/0x140 [cifs] > > [125545.835315] filp_flush+0x35/0x90 > > [125545.835329] filp_close+0x14/0x30 > > [125545.835341] put_files_struct+0x85/0xf0 > > [125545.835354] exit_files+0x47/0x60 > > [125545.835365] do_exit+0x295/0x530 > > [125545.835377] ? wake_up_state+0x10/0x20 > > [125545.835391] do_group_exit+0x35/0x90 > > [125545.835403] __x64_sys_exit_group+0x18/0x20 > > [125545.835414] do_syscall_64+0x74/0x140 > > [125545.835424] ? handle_mm_fault+0xad/0x380 > > [125545.835437] ? do_user_addr_fault+0x338/0x6b0 > > [125545.835446] ? irqentry_exit_to_user_mode+0x6b/0x1a0 > > [125545.835458] ? irqentry_exit+0x43/0x50 > > [125545.835467] ? exc_page_fault+0x94/0x1b0 > > [125545.835478] entry_SYSCALL_64_after_hwframe+0x6e/0x76 > > [125545.835490] RIP: 0033:0x7f9b67eea36d > > [125545.835549] RSP: 002b:00007ffde6442cd8 EFLAGS: 00000202 ORIG_RAX: > > 00000000000000e7 > > [125545.835560] RAX: ffffffffffffffda RBX: 00007f9b68000188 RCX: > > 00007f9b67eea36d > > [125545.835566] RDX: 00000000000000e7 RSI: ffffffffffffff28 RDI: > > 0000000000000000 > > [125545.835572] RBP: 0000000000000001 R08: 0000000000000000 R09: > > 0000000000000000 > > [125545.835576] R10: 00005b88e60ec720 R11: 0000000000000202 R12: > > 0000000000000000 > > [125545.835582] R13: 0000000000000000 R14: 00007f9b67ffe860 R15: > > 00007f9b680001a0 > > [125545.835597] </TASK> > > > > > > -- > > Thanks, > > > > Steve > > -- Thanks, Steve