Hi Linus,
Could you apply this, please? It's intended to improve the interaction of
arbitrary lookups in the AFS dynamic root that hit DNS lookup failures[1]
where kafs behaves differently from openafs and causes some applications to
fail that aren't expecting that. Further, negative DNS results aren't
getting removed and are causing failures to persist.
(1) Always delete unused (particularly negative) dentries as soon as
possible so that they don't prevent future lookups from retrying.
(2) Fix the handling of new-style negative DNS lookups in ->lookup() to
make them return ENOENT so that userspace doesn't get confused when
stat succeeds but the following open on the looked up file then fails.
(3) Fix key handling so that DNS lookup results are reclaimed almost as
soon as they expire rather than sitting round either forever or for an
additional 5 mins beyond a set expiry time returning EKEYEXPIRED.
They persist for 1s as /bin/ls will do a second stat call if the first
fails.
Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>
Thanks,
David
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216637 [1]
Link: https://lore.kernel.org/r/20231211163412.2766147-1-dhowells@xxxxxxxxxx/ # v1
Link: https://lore.kernel.org/r/20231211213233.2793525-1-dhowells@xxxxxxxxxx/ # v2
Link: https://lore.kernel.org/r/20231212144611.3100234-1-dhowells@xxxxxxxxxx/ # v3
Link: https://lore.kernel.org/r/20231221134558.1659214-1-dhowells@xxxxxxxxxx/ # v4
---
The following changes since commit ceb6a6f023fd3e8b07761ed900352ef574010bcb:
Linux 6.7-rc6 (2023-12-17 15:19:28 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20231221
for you to fetch changes up to 39299bdd2546688d92ed9db4948f6219ca1b9542:
keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry (2023-12-21 13:47:38 +0000)
----------------------------------------------------------------
AFS fixes
----------------------------------------------------------------
David Howells (3):
afs: Fix the dynamic root's d_delete to always delete unused dentries
afs: Fix dynamic root lookup DNS check
keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry
fs/afs/dynroot.c | 31 +++++++++++++++++--------------
include/linux/key-type.h | 1 +
net/dns_resolver/dns_key.c | 10 +++++++++-
security/keys/gc.c | 31 +++++++++++++++++++++----------
security/keys/internal.h | 11 ++++++++++-
security/keys/key.c | 15 +++++----------
security/keys/proc.c | 2 +-
7 files changed, 64 insertions(+), 37 deletions(-)
