On Fri, Nov 10, 2023 at 8:21 AM Steve French <smfrench@xxxxxxxxx> wrote: > > Updated patch to remove dumping of flags (tcon->Flags was already > supposed to be dumped via > the other ioctl (CIFS_IOC_GET_MNT_INFO) but it had a minor bug - will > send followon patch for that) > > > On Thu, Nov 9, 2023 at 3:51 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > [PATCH] smb3: allow debugging session and tcon info to improve stats > > analysis and debugging > > > > When multiple mounts are to the same share from the same client it was not > > possible to determine which section of /proc/fs/cifs/Stats (and DebugData) > > correspond to that mount. In some recent examples this turned out to be > > a significant problem when trying to analyze performance problems - since > > there are many cases where unless we know the tree id and session id we > > can't figure out which stats (e.g. number of SMB3.1.1 requests by type, > > the total time they take, which is slowest, how many fail etc.) apply to > > which mount. > > > > Add an ioctl to return tid, session id, tree connect count and tcon flags. > > > > -- > > Thanks, > > > > Steve > > > > -- > Thanks, > > Steve IMO, tc_count is not necessary here. We should keep this ioctl very specific to this use case. Moreover, DebugData already prints tc_count. -- Regards, Shyam
