On Fri, Aug 25, 2023 at 10:09 AM Steve French <smfrench@xxxxxxxxx> wrote: > > The ChannelSequence field in the SMB3 header is supposed to be > increased after reconnect to allow the server to distinguish > requests from before and after the reconnect. We had always > been setting it to zero. There are cases where incrementing > ChannelSequence on requests after network reconnects can reduce > the chance of data corruptions. > > See MS-SMB2 3.2.4.1 and 3.2.7.1 > > Note that (as Tom Talpey pointed out) a macro "CIFS_SERVER_IS_CHAN" used by this patch is confusing (has a confusing name) since multichannel is not supported for older dialects like CIFS. I will fix that macro name in a followon patch. > > -- > Thanks, > > Steve Theoretically seems okay. Although MS-SMB2 says that replay requests need to be indicated as replay in the header, which we are not doing currently. I don't know what maybe a side effect of not sending that could be. Will this patch without that make things worse? -- Regards, Shyam
