On Sat, Jul 22, 2023 at 1:24 PM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Sat, 22 Jul 2023 at 07:19, Steve French <smfrench@xxxxxxxxx> wrote: > > > > add small debugging improvement > > - it is helpful for network debugging of smb3 problems to be able to > > use directory not just file (e.g. access to empty share) > > ---------------------------------------------------------------- > > Shyam Prasad N (1): > > cifs: allow dumping keys for directories too > > > > Steve French (1): > > cifs: update internal module version number for cifs.ko > > Bah. I pulled, and then unpulled, because that module version number > change was obviously garbage. I had missed a line in the version update. Have now fixed that typo. The module version number is used e.g. to tell when someone has backported fixes for cifs.ko to an earlier kernel release (so e.g. we can see from "modinfo cifs" or "cat /proc/fs/cifs/DebugData | grep Version" whether they are running an updated version of cifs.ko or the default version for that kernel). I try to update the module version at the end of the merge window but have sometimes delayed updating it until after an important fix. > This pull wasn't really a "fix" anyway, but then when I see nonsense > like that I just decide it's entirely bogus. For some context on the debug improvement: - the keys change improves ability to read a network trace to debug problems on encrypted connections which are very common (e.g. using wireshark or tcpdump). That works today with tools like "smbinfo keys /mnt/file" but requires passing in a filename on the mount (see e.g. https://wiki.samba.org/index.php/Wireshark_Decryption), but it often makes more sense to just pass in the mount point path (ie a directory not a filename). And this fix was needed to debug some types of problems (an obvious example is on an encrypted connection failing operations on an empty share or with no files in the root of the directory) - so you can simply pass in the "smbinfo keys <mntpoint>" and get the information that wireshark needs. I have updated to correct the version missing line at git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc2-smb3-client-fixes-ver2 -- Thanks, Steve
