Re: [PATCH] fs/nls: make load_nls() take a const parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Winston Wen <wentao@xxxxxxxxxxxxx> writes:

> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
>
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
>
>         ses->local_nls = load_nls((char *)ctx->local_nls->charset);
>
> Also remove the cast in cifs code.
>
> Suggested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Winston Wen <wentao@xxxxxxxxxxxxx>
> ---
>  fs/nls/nls_base.c       | 4 ++--
>  fs/smb/client/connect.c | 2 +-
>  include/linux/nls.h     | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

Changes look good, however you should probably get rid of the cifs.ko
changes in this patch and for the cifs.ko one, you could resend without
the casts.



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux