Question about NTLMSSP_NEGOTIATE_VERSION in NTLM messages

Roy Shterman <roy.shterman@xxxxxxxxx> · Tue, 18 Jul 2023 18:19:19 +0300

Hi,

I see that in the commit bellow we added Version into the negotiate message:
commit 52d005337b2c94ab37273d9ad8382d4fb051defd
Author: Steve French <stfrench@xxxxxxxxxxxxx>
Date:   Wed Jan 19 22:00:29 2022 -0600

    smb3: send NTLMSSP version information

    For improved debugging it can be helpful to send version information
    as other clients do during NTLMSSP negotiation. See protocol document
    MS-NLMP section 2.2.1.1

    Set the major and minor versions based on the kernel version, and the
    BuildNumber based on the internal cifs.ko module version number,
    and following the recommendation in the protocol documentation
    (MS-NLMP section 2.2.10) we set the NTLMRevisionCurrent field to 15.

    Reviewed-by: Shyam Prasad N <sprasad@xxxxxxxxxxxxx>
    Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>

Now if I understand correctly the server side should return in
negotiate flags the flags he got from the client and that it supports.
It means that in auth_message where we construct the negotiate flags
we will have the NTLMSSP_NEGOTIATE_VERSION flag as well although we
are not sending the version as part of the message.

Doesn't it contradict the MS-NLMP spec?

Thanks,
Roy