On 6/27/2023 8:09 AM, Shyam Prasad N wrote:
Having the ClientGUID info makes it easier to debug issues related to a client on a server that serves a number of clients. This change prints the ClientGUID in DebugData.
Good idea.
Signed-off-by: Shyam Prasad N <sprasad@xxxxxxxxxxxxx> --- fs/smb/client/cifs_debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c index 079c1df09172..f5af080ac100 100644 --- a/fs/smb/client/cifs_debug.c +++ b/fs/smb/client/cifs_debug.c @@ -347,6 +347,7 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v) spin_lock(&server->srv_lock); if (server->hostname) seq_printf(m, "Hostname: %s ", server->hostname); + seq_printf(m, "\nClientGUID: %pUL", server->client_guid); spin_unlock(&server->srv_lock);
It's a totally minor thing, but does this code really need to take the server lock? These elements never change anyway. In any case: Acked-by: Tom Talpey <tom@xxxxxxxxxx>
#ifdef CONFIG_CIFS_SMB_DIRECT if (!server->rdma)
