Re: [PATCH 3/3] cifs: fix session state check in smb2_find_smb_ses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2023 at 9:24 AM Winston Wen <wentao@xxxxxxxxxxxxx> wrote:
>
> Chech the session state and skip it if it's exiting.
>
> Signed-off-by: Winston Wen <wentao@xxxxxxxxxxxxx>
> ---
>  fs/smb/client/smb2transport.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c
> index 790acf65a092..22954a9c7a6c 100644
> --- a/fs/smb/client/smb2transport.c
> +++ b/fs/smb/client/smb2transport.c
> @@ -153,7 +153,14 @@ smb2_find_smb_ses_unlocked(struct TCP_Server_Info *server, __u64 ses_id)
>         list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
>                 if (ses->Suid != ses_id)
>                         continue;
> +
> +               spin_lock(&ses->ses_lock);
> +               if (ses->ses_status == SES_EXITING) {
> +                       spin_unlock(&ses->ses_lock);
> +                       continue;
> +               }
>                 ++ses->ses_count;
> +               spin_unlock(&ses->ses_lock);
>                 return ses;
>         }
>
> --
> 2.40.1
>

Thanks for the change.
Looks good to me.
CC stable for this one too.

-- 
Regards,
Shyam




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux