On 6/19/2023 9:52 PM, Steve French wrote:
We had seen cases where cifs_invalidate_mapping was logging: "Could not invalidate inode ..." if invalidate_inode_pages2 fails but this message does not show what the rc is. Update the logged message to also log the return code. Suggested-by: Shyam Prasad N <sprasad@xxxxxxxxxxxxx> (see attached)
It's reasonable, but should we be printing kernel addresses like this? Thinking Spectre, and all. Wouldn't printing the inode number etc be more useful? Tom.