On Tue, Jun 20, 2023 at 9:12 AM Steve French <smfrench@xxxxxxxxx> wrote: > > There were cases reported where servers will sometimes return more > credits than requested on oplock break responses, which can lead to > most of the credits being allocated for oplock breaks (instead of > for normal operations like read and write) if number of SMB3 requests > in flight always stays above 0 (the oplock and echo credits are > rebalanced when in flight requests goes down to zero). > > If oplock credits gets unexpectedly large (e.g. ten is more than it > would ever be expected to be) and in flight requests are greater than > zero, then rebalance the oplock credits and regular credits (go > back to reserving just one oplock credit. > > See attached > > -- > Thanks, > > Steve Hi Steve, > If oplock credits gets unexpectedly large (e.g. ten is more than it > would ever be expected to be) and in flight requests are greater than > zero, then rebalance the oplock credits and regular credits (go > back to reserving just one oplock crdit). Why this value of 10? I would go with 1, since we already reserve 1 credit for oplocks. If the reasoning is to have enough credits to send multiple lease/oplock acks, we should change the reserved count altogether. -- Regards, Shyam
