Hi Thiago, kernel test robot noticed the following build warnings: [auto build test WARNING on cifs/for-next] [also build test WARNING on linus/master v6.3-rc5 next-20230404] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thiago-Becker/cifs-sanitize-paths-in-cifs_update_super_prepath/20230405-030114 base: git://git.samba.org/sfrench/cifs-2.6.git for-next patch link: https://lore.kernel.org/r/20230404185908.993738-1-tbecker%40redhat.com patch subject: [PATCH] cifs: sanitize paths in cifs_update_super_prepath. config: x86_64-randconfig-a003-20230403 (https://download.01.org/0day-ci/archive/20230405/202304050627.7O0sKgk8-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4d179c3f90c01aab96bf6a02f70cc111da39d61c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thiago-Becker/cifs-sanitize-paths-in-cifs_update_super_prepath/20230405-030114 git checkout 4d179c3f90c01aab96bf6a02f70cc111da39d61c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/cifs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304050627.7O0sKgk8-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/cifs/fs_context.c:448:7: warning: no previous prototype for function 'sanitize_path' [-Wmissing-prototypes] char *sanitize_path(char *path, gfp_t gfp) ^ fs/cifs/fs_context.c:448:1: note: declare 'static' if the function is not intended to be used outside of this translation unit char *sanitize_path(char *path, gfp_t gfp) ^ static 1 warning generated. vim +/sanitize_path +448 fs/cifs/fs_context.c 438 439 /* 440 * Remove duplicate path delimiters. Windows is supposed to do that 441 * but there are some bugs that prevent rename from working if there are 442 * multiple delimiters. 443 * 444 * Returns a sanitized duplicate of @path. The caller is responsible for 445 * cleaning up the original. 446 */ 447 #define IS_DELIM(c) ((c) == '/' || (c) == '\\') > 448 char *sanitize_path(char *path, gfp_t gfp) 449 { 450 char *cursor1 = path, *cursor2 = path; 451 452 /* skip all prepended delimiters */ 453 while (IS_DELIM(*cursor1)) 454 cursor1++; 455 456 /* copy the first letter */ 457 *cursor2 = *cursor1; 458 459 /* copy the remainder... */ 460 while (*(cursor1++)) { 461 /* ... skipping all duplicated delimiters */ 462 if (IS_DELIM(*cursor1) && IS_DELIM(*cursor2)) 463 continue; 464 *(++cursor2) = *cursor1; 465 } 466 467 /* if the last character is a delimiter, skip it */ 468 if (IS_DELIM(*(cursor2 - 1))) 469 cursor2--; 470 471 *(cursor2) = '\0'; 472 return kstrdup(path, gfp); 473 } 474 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
