Re: [PATCH] ksmbd: avoid duplicate negotiate ctx offset increments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2023-04-04 7:47 GMT+09:00, David Disseldorp <ddiss@xxxxxxx>:
> Both pneg_ctxt and ctxt_size change in unison, with each adding the
> length of the previously added context, rounded up to an eight byte
> boundary.
> Drop pneg_ctxt increments and instead use the ctxt_size offset when
> passing output pointers to per-context helper functions. This slightly
> simplifies offset tracking and shaves off a few text bytes.
> Before (x86-64 gcc 7.5):
>    text    data     bss     dec     hex filename
>  213234    8677     672  222583   36577 ksmbd.ko
>
> After:
>    text    data     bss     dec     hex filename
>  213218    8677     672  222567   36567 ksmbd.ko
>
> Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>

> ---
> Note: this applies atop my previous assemble_neg_contexts cleanup
>   ksmbd: set NegotiateContextCount once instead of every inc
Okay:) Thanks for your patch!



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux