I like all these changes but I think #5 should be split out into a standalone patch. It changes the rmdir wire semantics so it's not just a cleanup. Acked-by: Tom Talpey <tom@xxxxxxxxxx> On 3/15/2023 9:05 AM, Volker Lendecke wrote:
These are some cleanups and simplifications to fs/cifs which helped me understand the code a bit better. Volker Lendecke (10): cifs: Simplify some callers of compound_send_recv() cifs: Make "resp_buf_type" initialization consistent cifs: Slightly simplify cifs_readdir() cifs: Slightly simplify cifs_readdir() cifs: Simplify SMB2_OP_RMDIR with CREATE_DELETE_ON_CLOSE cifs: Slightly refactor smb2_compound_op() cifs: Reduce copy&paste in smb2_compound_op() cifs: Avoid two "else" branches cifs: Store smb3_create_tag_posix just once cifs: Use switch/case to dissect negprot reply ctxts fs/cifs/cached_dir.c | 1 - fs/cifs/cifssmb.c | 6 +- fs/cifs/readdir.c | 6 +- fs/cifs/smb2inode.c | 163 +++++++++++++------------------------------ fs/cifs/smb2ops.c | 7 -- fs/cifs/smb2pdu.c | 92 ++++++++++-------------- 6 files changed, 91 insertions(+), 184 deletions(-)
