we also should probably go through all the places that we call SMB2_open_init - various compounded cases and make sure that we request leases when it makes sense (we are missing a few for directory leases e.g.) On Thu, Feb 9, 2023 at 11:50 AM Volker Lendecke <Volker.Lendecke@xxxxxxxxx> wrote: > > Hi! > > Attached find a patch that fixes another case where oparms.mode is > uninitialized. This patch fixes it with a struct assignment, relying > on the implicit initialization of unmentioned fields. Please note that > the assignment does not explicitly mention "reconnect" anymore, > relying on the implicit "false" value. > > Is this kernel-style? Shall we just go through all of the oparms > initializations, there are quite a few other cases that might have the > mode uninitialized. > > Regards, > > Volker -- Thanks, Steve
