Pali Rohár <pali@xxxxxxxxxx> writes: >> This patch fixes the issue of utf-8 partially only. I think we can't >> still recommend only partially working one. > > With this patch FAT_DEFAULT_IOCHARSET=utf8 is same what was > FAT_DEFAULT_UTF8=y without this patch. And option FAT_DEFAULT_UTF8 was > recommended in description before "select the next option instead if you > would like to use UTF-8 encoded file names by default." It is not recommending to use UTF-8 as default, right? I wanted to say no warning and recommend has big difference, and I can't recommend the incompatible behavior that creates the case sensitive filename. >> Still broken, so I think we still need the warning here (would be >> tweaked warning). > > There was no warning before for utf8=1. And with this patch > iocharset=utf8 should have same behavior as what was utf8=1 before this > patch. > > So if we should show some warning for utf8=1 then it is somehow not > related to this patch and it should be done separately, possible also to > the current codebase and before this patch. Sure, you are right. Thanks. -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
