updated On Thu, Jan 12, 2023 at 7:24 AM David Disseldorp <ddiss@xxxxxxx> wrote: > > Hi Volker, > > On Wed, 11 Jan 2023 12:42:52 +0100, Volker Lendecke wrote: > > > If smb311 posix is enabled, we send the intended mode for file > > creation in the posix create context. Instead of using what's there on > > the stack, create the mfsymlink file with 0644. > > > > Signed-off-by: Volker Lendecke <vl@xxxxxxxxx> > > Good catch. I think this deserves a Fixes tag as per > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes > E.g. > Fixes: ce558b0e17f8a ("smb3: Add posix create context for smb3.11 posix mounts") > Preferably also with "Cc: stable@xxxxxxxxxxxxxxx" for applicable > backports. > > oparms.mode appears to be uninitialized in cifs_create_mf_symlink() > (#ifdef CONFIG_CIFS_ALLOW_INSECURE_LEGACY) and various other codepaths > but isn't currently used further down the call chain... This looks like > an accident waiting to happen. > > Cheers, David -- Thanks, Steve
