On Tue, Oct 18, 2022 at 3:22 AM Steve French <smfrench@xxxxxxxxx> wrote: > > Updated one is also at > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=patch;h=3f825b8fa93bb300e60c932753e8c5274b253a77 > > On Mon, Oct 17, 2022, 16:28 Tom Talpey <tom@xxxxxxxxxx> wrote: >> >> On 10/17/2022 5:26 PM, Steve French wrote: >> > >> > >> > On Mon, Oct 17, 2022, 16:03 Tom Talpey <tom@xxxxxxxxxx >> > <mailto:tom@xxxxxxxxxx>> wrote: >> > >> > On 10/15/2022 6:10 PM, Steve French wrote: >> > > smb3: interface count displayed incorrectly >> > > >> > > The "Server interfaces" count in /proc/fs/cifs/DebugData increases >> > > as the interfaces are requeried, rather than being reset to the new >> > > value. This could cause a problem if the server disabled >> > > multichannel as the iface_count is checked in try_adding_channels >> > > to see if multichannel still supported. >> > > >> > > Cc: <stable@xxxxxxxxxxxxxxx <mailto:stable@xxxxxxxxxxxxxxx>> >> > > >> > > See attached >> > > >> > >> > This zeroes the ses->iface_count under the lock, but the whole >> > routine is dropping and re-taking the same lock many times, >> > and finally sets the iface_count without holding the lock at >> > all. >> > >> > >> > I updated the patch earlier today to fix that existing issue as well >> > (served into same patch). If I missed something let me know >> >> I was just looking at the patch attached to the message I replied to. >> I'll look again, but it will have to be tomorrow. >> >> Tom. Looks good to me for fixing the issue. One or two more changes needed in this area. You can expect additional patches from me in the coming days. -- Regards, Shyam
