Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Tue, Aug 23, 2022 at 03:12:14PM +0100, David Howells wrote: > > Copy cifs's setup_aio_ctx_iter() and to lib/iov_iter.c and generalise it as > > extract_iter_to_iter(). This allocates and sets up an array of bio_vecs > > for all the page fragments in an I/O iterator and sets a second supplied > > iterator to bvec-type pointing to the array. > > Did you read my NACK and comments from last time? No, because they ended up in a different mailbox from everything else for some reason. > I really do not like this as a general purpose helper. This is an odd > quirk that we really generally should not needed unless you have very > convoluted locking. So please keep it inside of cifs. I'm using it in under-development netfslib code also. Let me ask the question more generally in a separate email. David
