Re: [PATCH v5] ksmbd: validate share name from share config response

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2022-10-03 8:09 GMT+09:00, Atte Heikkilä <atteh.mailbox@xxxxxxxxx>:
> Share config response may contain the share name without casefolding as
> it is known to the user space daemon. When it is present, casefold and
> compare it to the share name the share config request was made with. If
> they differ, we have a share config which is incompatible with the way
> share config caching is done. This is the case when CONFIG_UNICODE is
> not set, the share name contains non-ASCII characters, and those non-
> ASCII characters do not match those in the share name known to user
> space. In other words, when CONFIG_UNICODE is not set, UTF-8 share
> names now work but are only case-insensitive in the ASCII range.
>
> Signed-off-by: Atte Heikkilä <atteh.mailbox@xxxxxxxxx>
I agreed that Tom's review comments should be changed
ksmbd/ksmbd-tools together.
I will make another clean-up patches included Tom's comments.

For this patch,
Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>

Thanks for your work!




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux