improved ... but I see an out of memory error when I do this: # dd if=/dev/zero of=/mnt1/file bs=4M count=1 dd: closing output file '/mnt1/file': Cannot allocate memory # dmesg [ 439.674953] CIFS: VFS: \\localhost smb311_calc_aes_gmac: Failed to compute AES-GMAC signature, rc=-12 Attached is the trace-cmd output Will also run some xfstests with this v4 series On Thu, Sep 29, 2022 at 3:36 PM Enzo Matsumiya <ematsumiya@xxxxxxx> wrote: > > v4: > Patches 3/8 and 6/8: > - fix checkpatch errors (thanks to Steve) > > Patch 5/8: > - rename smb311_calc_signature to smb311_calc_aes_gmac, and use SMB3_AES_GCM_NONCE > instead of hardcoded '12' (suggested by metze) > - update commit message to include the reasoning to move ->calc_signature op > > Patch 8/8: > - move SMB2_PADDING_BUF to smb2glob.h > - check if iov is SMB2_PADDING_BUF in the free functions where > smb2_padding was previously used (pointed out by metze) > > Enzo Matsumiya (8): > smb3: rename encryption/decryption TFMs > cifs: secmech: use shash_desc directly, remove sdesc > cifs: allocate ephemeral secmechs only on demand > cifs: create sign/verify secmechs, don't leave keys in memory > cifs: introduce AES-GMAC signing support for SMB 3.1.1 > cifs: deprecate 'enable_negotiate_signing' module param > cifs: show signing algorithm name in DebugData > cifs: use MAX_CIFS_SMALL_BUFFER_SIZE-8 as padding buffer > > fs/cifs/cifs_debug.c | 7 +- > fs/cifs/cifsencrypt.c | 157 ++++------- > fs/cifs/cifsfs.c | 14 +- > fs/cifs/cifsglob.h | 70 +++-- > fs/cifs/cifsproto.h | 5 +- > fs/cifs/link.c | 13 +- > fs/cifs/misc.c | 49 ++-- > fs/cifs/sess.c | 12 - > fs/cifs/smb1ops.c | 6 + > fs/cifs/smb2glob.h | 15 ++ > fs/cifs/smb2misc.c | 29 +- > fs/cifs/smb2ops.c | 102 ++----- > fs/cifs/smb2pdu.c | 77 ++++-- > fs/cifs/smb2pdu.h | 2 - > fs/cifs/smb2proto.h | 13 +- > fs/cifs/smb2transport.c | 581 +++++++++++++++++++++------------------- > 16 files changed, 577 insertions(+), 575 deletions(-) > > -- > 2.35.3 > -- Thanks, Steve
Attachment:
failed-4mb-write-with-signing
Description: Binary data
