On Thu, Sep 22, 2022 at 10:52:43PM -0500, Steve French wrote: > Looks like the SMB1 Protocol operations for get/set posix ACL were > removed in the companion patch (in SMB3, POSIX ACLs have to be handled Sorry, what companion patch? Is a patch in this series or are you referring to something else? > by mapping from rich acls). Was this intentional or did I miss > something? I didn't see the functions for sending these over the wire > for SMB1 (which does support POSIX ACLs, not just RichACLs (SMB/NTFS > ACLs)) I'm sorry, I don't understand. This is basically a 1:1 port of what you currently have in cifs_xattr_set() and cifs_xattr_get() under the XATTR_ACL_DEFAULT and XATTR_ACL_ACCESS switches. So basically, the patches in this series just add almost 1:1 copies of CIFSSMBSetPosixACL() and CIFSSMBGetPosixACL() just that instead of operating on void * they operate on a proper vfs struct posix acl. So nothing would've changed behavior wise. Ofc, there's always the chance that I missed sm especially bc I'm not a cifs developer. :) > > pSMB->SubCommand = cpu_to_le16(TRANS2_SET_PATH_INFORMATION); > pSMB->InformationLevel = cpu_to_le16(SMB_SET_POSIX_ACL);
