On 9/14/2022 4:09 AM, Atte Heikkilä wrote:
On Tue, 13 Sep 2022 12:02:47 -0700, Tom Talpey wrote:
On 9/12/2022 4:54 PM, Namjae Jeon wrote:
2022-09-13 8:38 GMT+09:00, Tom Talpey <tom@xxxxxxxxxx>:
I missed this in the v2 match - are you intentionally moving the
ksmbd.conf file to /usr/local/etc? That seems a very mysterious
location. Nothing on my vanilla installed system places anything
in there.
To avoid conflicts with the existing distribution package, the default
location as far as I know is /usr/local/etc. And it can be changed
with --sysconfdir. It is same with samba.
I totally disagree with this. The kernel server is part of, well,
the kernel, and loading the kernel should not depend on a path like
/usr/local/etc.
I really don't understand what this means. The dependency to the
sysconfdir path isn't ksmbd's, it's ksmbd-tools'.
But ksmbd depends on the ksmbd-tools to provide the configuration
to the kernel module, and to manage the service. So, the user/admin
will view them as one subsystem.
Also, nothing I know, including Samba, is deployed
with such a directory in my experience. I find smb.conf in /etc/samba.
Yes, that is because your distribution builds it for you. If you build it
yourself, and don't want to collide with your distribution's packaged
version of it, then you choose some prefix other than /usr.
I understand that. My point is that distributions have already
built ksmbd-tools with sysconfdir==/etc, which IMO is appropriate
and correct.
Where are the ksmbd.<foo> helpers installed by default? /usr/local/sbin?
On my standard Ubuntu install (and presumably Debian?) they are in
/sbin.
Yes, the GNU autoconf default sbindir is /usr/local/sbin since the default
prefix is /usr/local. It is distinct from the sbindir your distribution's
packages use. Your /sbin is (likely) a symlink to /usr/sbin and the
distribution's packages install in the /usr prefix. The /etc sysconfdir
is associated with the /usr prefix. You can also check what FHS has to
say about /usr/local if you'd like.
Namjae's way of running configure is correct. It's either this or colliding
with file paths used by the packaged ksmbd-tools, which isn't a good idea.
Ok, so if overriding the default sysconfdir builds the manpage
output to follow, we're good here. Out of step, perhaps, but good.
Tom.
Tom.
Also, doesn't this file need to exist before step 2??
Ah, Yes. Will switch them.
Thanks for your review!
Tom.
